greg/webauthn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes static analysis

Browse Source
This commit is contained in:
Italo
2022-07-27 14:03:56 -04:00
committed by GitHub
parent c02f826928
commit 21db20d103
4 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Assertion/Creator/Pipes/CreateAssertionChallenge.php
View File

@@ -33,6 +33,7 @@ class CreateAssertionChallenge
$options = []; $options = [];
if ($assertion->acceptedCredentials?->isNotEmpty()) { if ($assertion->acceptedCredentials?->isNotEmpty()) {
// @phpstan-ignore-next-line
$options['credentials'] = $assertion->acceptedCredentials->map->getKey()->toArray(); $options['credentials'] = $assertion->acceptedCredentials->map->getKey()->toArray();
} }

2
src/Assertion/Creator/Pipes/MayRetrieveCredentialsIdForUser.php
View File

@@ -36,7 +36,7 @@ class MayRetrieveCredentialsIdForUser
* Adapt all credentials into an `allowCredentials` digestible array. * Adapt all credentials into an `allowCredentials` digestible array.
* *
* @param \Illuminate\Database\Eloquent\Collection<int, \Laragear\WebAuthn\Models\WebAuthnCredential> $credentials * @param \Illuminate\Database\Eloquent\Collection<int, \Laragear\WebAuthn\Models\WebAuthnCredential> $credentials
* @return \Illuminate\Support\Collection<int, array> * @return Illuminate\Support\Collection<int, array{id?: mixed, type: string, transports?: non-empty-array<int, string>}>
*/ */
protected function parseCredentials(EloquentCollection $credentials): Collection protected function parseCredentials(EloquentCollection $credentials): Collection
{ {

1
src/Assertion/Validator/Pipes/CheckCredentialIsForUser.php
View File

@@ -56,6 +56,7 @@ class CheckCredentialIsForUser
*/ */
protected function validateUser(AssertionValidation $validation): void protected function validateUser(AssertionValidation $validation): void
{ {
// @phpstan-ignore-next-line
if ($validation->credential->authenticatable()->isNot($validation->user)) { if ($validation->credential->authenticatable()->isNot($validation->user)) {
throw AssertionException::make('User is not owner of the stored credential.'); throw AssertionException::make('User is not owner of the stored credential.');
} }

4
src/Attestation/AuthenticatorData.php
View File

@@ -76,10 +76,10 @@ class AuthenticatorData
* @param string $relyingPartyIdHash * @param string $relyingPartyIdHash
* @param object $flags * @param object $flags
* @param int $counter * @param int $counter
* @param object{aaguid: int|bool, credentialId: string, credentialPublicKey: string} $attestedCredentialData * @param object $attestedCredentialData
* @param array $extensionData * @param array $extensionData
*/ */
public function __construct( final public function __construct(
public string $relyingPartyIdHash, public string $relyingPartyIdHash,
public object $flags, public object $flags,
public int $counter, public int $counter,